[plt-scheme] Re: Framework bug involving snips and transpose-sexp

Thanks, Danny and sorry for the wait. I've checked this in to SVN.

Robby

On 9/26/07, Danny Yoo <dyoo at cs.wpi.edu> wrote:
>
> Hi everyone,
>
>
> I didn't want to let this slip: here's a bug fix for the problem involving
> transpose-sexp and snips.
>
>
> --------
>
> dyoo at kfisler-ra1:~/local/plt-svn/collects$ svn diff
> framework/private/scheme.ss
> Index: framework/private/scheme.ss
> ===================================================================
> --- framework/private/scheme.ss (revision 7416)
> +++ framework/private/scheme.ss (working copy)
> @@ -1031,6 +1031,26 @@
>                        (change-style matching-parenthesis-style pos (+ pos
> 1))
>                        (change-style matching-parenthesis-style (- end 1)
> end)])))))))
>
> +
> +      ;; get-snips/rev: start end -> (listof snip)
> +      ;; Returns a list of the snips in reverse order between
> +      ;; start and end.
> +      (define (get-snips/rev start end)
> +        (split-snip start)
> +        (split-snip end)
> +        (let loop ([snips/rev '()]
> +                   [a-snip
> +                    (find-snip start 'after-or-none)])
> +          (cond
> +            [(or (not a-snip)
> +                 (>= (get-snip-position a-snip)
> +                     end))
> +             snips/rev]
> +            [else
> +             (loop (cons (send a-snip copy) snips/rev)
> +                   (send a-snip next))])))
> +
> +
>         (define/public (transpose-sexp pos)
>           (let ([start-1 (get-backward-sexp pos)])
>             (if (not start-1)
> @@ -1045,13 +1065,15 @@
>                               (if (or (not start-2)
>                                       (< start-2 end-1))
>                                   (bell)
> -                                (let ([text-1
> -                                       (get-text start-1 end-1)]
> -                                      [text-2
> -                                       (get-text start-2 end-2)])
> +                                (let ([snips-1/rev
> +                                       (get-snips/rev start-1 end-1)]
> +                                      [snips-2/rev
> +                                       (get-snips/rev start-2 end-2)])
>                                     (begin-edit-sequence)
> -                                  (insert text-1 start-2 end-2)
> -                                  (insert text-2 start-1 end-1)
> +                                  (delete start-2 end-2)
> +                                  (for-each (lambda (s) (insert s
> start-2)) snips-1/rev)
> +                                  (delete start-1 end-1)
> +                                  (for-each (lambda (s) (insert s
> start-1)) snips-2/rev)
>                                     (set-position end-2)
>                                     (end-edit-sequence)))))))))))
>         [define tab-size 8]
>
> _________________________________________________
>   For list-related administrative tasks:
>   http://list.cs.brown.edu/mailman/listinfo/plt-scheme
>