<div dir="ltr">FWIW, I wouldn't mind if someone wanted to add a flag to "raco test" that took a collection (or subcollection) and followed some standardized way to test it. I think that would help us bring the collections in line to test them that way. <div> <br></div><div>It would probably work best if we had someone that was actually willing to do the work to get a large number of collections to follow the plan, whatever "raco test --collection" ends up doing.<br> <div><br>Robby</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 28, 2013 at 6:42 AM, Jay McCarthy <span dir="ltr"><<a href="mailto:jay.mccarthy@gmail.com" target="_blank">jay.mccarthy@gmail.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wed, Feb 27, 2013 at 2:34 PM, Danny Yoo <<a href="mailto:dyoo@hashcollision.org">dyoo@hashcollision.org</a>> wrote:<br> > On Wed, Feb 27, 2013 at 1:36 PM, Robby Findler<br> > <<a href="mailto:robby@eecs.northwestern.edu">robby@eecs.northwestern.edu</a>> wrote:<br> >> I think that currently you can look at what drdr does. That's the best we<br> >> have.<br> ><br> > I'll assume that this is the drdr collection in meta,<br> ><br> > <a href="http://git.racket-lang.org/plt/tree/HEAD:/collects/meta/drdr" target="_blank">http://git.racket-lang.org/plt/tree/HEAD:/collects/meta/drdr</a><br> ><br> > and not the drdr2 directory, right?<br> ><br> <br> </div>No, I think Robby means (because it is what I would suggest) just go<br> to <a href="http://drdr.racket-lang.org" target="_blank">drdr.racket-lang.org</a> and see what gets run from the tests directory<br> and the collection source directory.<br> <div class="im"><br> ><br> >> Meanwhile, I think that if you are willing to live a bit on the edge, you<br> >> can try to run some reasonable looking tests (break something intentionally<br> >> and make sure they complain, say) and then go ahead and push and let drdr<br> >> sort things out more. Worst comes to worst, you just revert a commit and try<br> >> again tomorrow, no?<br> ><br> > I am somewhat risk averse. "Skittish" is probably apt. I'd prefer to<br> > rerun re-run a collection-wide test immediately after a bug fix, while<br> > the change is still fresh in my mind. Some collections are harder to<br> > test this way, so DrDr plays its role, but for algorithmic or<br> > data-structure stuff, I should be able to easily run the tests that I<br> > can execute locally, before committing a patch to the central<br> > repository.<br> <br> </div>I think it would be good to be able to say "raco test -c collection<br> tests/collection" does everything. You've found a case where that<br> fails, which while not exactly an error is non-robust code that could<br> change.<br> <div class="im"><br> > I can already do this, by spending time reading through the collection<br> > tree till I find the modules that drive the unit tests. Sometimes I<br> > do a manual "grep -r" for the word 'test' and hope for the best. I<br> > just wish I didn't have to do that manual search. And I sometimes get<br> > it wrong; e.g. the datalog thing from a day ago: I was testing a<br> > change to parser-tools, but couldn't find any tests for the<br> > parser-tools collection. The next best thing I could do was run tests<br> > on the collections that _use_ parser-tools, and that's how this topic<br> > got started.<br> <br> </div>However, you'll never be able to cleanly specify what other<br> collections/modules you should look at it. Maybe when the majority of<br> the core are packages that express their dependencies you could run<br> the things that depend on what you are changing, but even then I doubt<br> you should be willing to do that.<br> <span class="HOEnZb"><font color="#888888"><br> Jay<br> <br> --<br> Jay McCarthy <<a href="mailto:jay@cs.byu.edu">jay@cs.byu.edu</a>><br> Assistant Professor / Brigham Young University<br> <a href="http://faculty.cs.byu.edu/~jay" target="_blank">http://faculty.cs.byu.edu/~jay</a><br> <br> "The glory of God is Intelligence" - D&C 93<br> </font></span></blockquote></div><br></div>