On Fri, Oct 5, 2012 at 11:47 AM, Eli Barzilay <span dir="ltr"><<a href="mailto:eli@barzilay.org" target="_blank">eli@barzilay.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tuesday, Carl Eastlund wrote:<br>
> Oops, I hadn't meant to push that to the main repository without<br>
> consulting anyone. Hope this change is okay, it seemed weird for<br>
> read-json to error instead of producing eof.<br>
<br>
</div>I think that the change is ok (and the added test shows a point for<br>
doing it). But the implementation is broken:<br>
<br>
-> (string->jsexpr "]")<br>
#<eof><br>
-> (string->jsexpr "ndljvnldj")<br>
#<eof><br>
<br>
Also, there's no reason for a keyword there, right?<br>
<br>
(I'm committing a fixed version.)<br></blockquote><div><br>Thanks for the fix. And no, the keyword doesn't matter.<br><br>--Carl<br></div></div><br>