[racket-dev] [plt] Push #26313: master branch updated

From: Jay McCarthy (jay.mccarthy at gmail.com)
Date: Mon Mar 4 08:30:35 EST 2013

2d5884b broke some of my Scribble documents.

The test that you removed previously failed, so the "on this page"
list was blank, but now I get this error:

cdr: contract violation
  expected: pair?
  given: '()
  context...:
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:531:4:
render-onthispage-contents method in ...bble/html-render.rkt:216:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:410:4:
render-toc-view method in ...bble/html-render.rkt:216:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:648:4:
render-one-part method in ...bble/html-render.rkt:216:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:1601:4:
render-part method in ...bble/html-render.rkt:1471:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:957:12: loop
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:915:4:
render-part-content method in ...bble/html-render.rkt:216:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:648:4:
render-one-part method in ...bble/html-render.rkt:216:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:1601:4:
render-part method in ...bble/html-render.rkt:1471:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:915:4:
render-part-content method in ...bble/html-render.rkt:216:2
   /home/jay/Dev/scm/plt/collects/scribble/html-render.rkt:648:4:
render-one-part method in ...bble/html-render.rkt:216:2
   /home/jay/Dev/scm/plt/collects/scribble/../racket/private/map.rkt:37:19: loop
   /home/jay/Dev/scm/plt/collects/scribble/render.rkt:30:0: render31
   /home/jay/Dev/scm/plt/collects/scribble/run.rkt: [running body]

I can link you to the full code, but it is a section (created by
@title) with the 'toc and 'unnumbered styles. It generates this page:

http://jeapostrophe.github.com/archive.html

If I put your test back in, it works just fine.

Jay

On Mon, Feb 18, 2013 at 5:39 PM,  <mflatt at racket-lang.org> wrote:
> mflatt has updated `master' from 7323dde0ea to 2d5884b26a.
>   http://git.racket-lang.org/plt/7323dde0ea..2d5884b26a
>
> =====[ 2 Commits ]======================================================
> Directory summary:
>   41.4% collects/games/
>   58.5% collects/scribble/
>
> ~~~~~~~~~~
>
> d043a08 Matthew Flatt <mflatt at racket-lang.org> 2013-02-18 17:20
> :
> | fix `plt-games' launcher
> :
>   M collects/games/info.rkt | 4 ++--
>
> ~~~~~~~~~~
>
> 2d5884b Matthew Flatt <mflatt at racket-lang.org> 2013-02-18 17:34
> :
> | scribble: fix "on this page" rendering
> |
> | A recent change improved "on this page" handling and also
> | fixed a short-circuit test to almost certainly do what
> | was originally intended, but the test was wrong, so just
> | get rid of it.
> :
>   M collects/scribble/html-render.rkt | 7 +------
>
> =====[ Overall Diff ]===================================================
>
> collects/games/info.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/collects/games/info.rkt
> +++ NEW/collects/games/info.rkt
> @@ -2,5 +2,5 @@
>
>  (define scribblings '(("scribblings/games.scrbl" (multi-page) (gui-library))))
>
> -(define racket-gui-launcher-libraries (list "main.rkt"))
> -(define racket-gui-launcher-names (list "PLT Games"))
> +(define gracket-launcher-libraries (list "main.rkt"))
> +(define gracket-launcher-names (list "PLT Games"))
>
> collects/scribble/html-render.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/collects/scribble/html-render.rkt
> +++ NEW/collects/scribble/html-render.rkt
> @@ -529,11 +529,6 @@
>                    h?)))
>
>      (define/private (render-onthispage-contents d ri top box-class sections-in-toc?)
> -      (if (andmap (lambda (p) (or (part-whole-page? p ri)
> -                                  (and (part-style? p 'toc-hidden)
> -                                       (all-toc-hidden? p))))
> -                  (part-parts d))
> -        null
>          (let ([nearly-top? (lambda (d)
>                               ;; If ToC would be collapsed, then
>                               ;; no section is nearly the top
> @@ -640,7 +635,7 @@
>                                                          "???")
>                                                      (element-content p))
>                                                  d ri)))))))))
> -                         ps))))))))
> +                         ps)))))))
>
>      (define/public (extract-part-body-id d ri)
>        (or (ormap (lambda (v)



--
Jay McCarthy <jay at cs.byu.edu>
Assistant Professor / Brigham Young University
http://faculty.cs.byu.edu/~jay

"The glory of God is Intelligence" - D&C 93

Posted on the dev mailing list.