[racket-dev] [plt] Push #26989: master branch updated

From: Matthew Flatt (mflatt at cs.utah.edu)
Date: Thu Jun 20 08:30:09 EDT 2013

At Thu, 20 Jun 2013 06:58:04 -0400, Eli Barzilay wrote:
> Yesterday, Eli Barzilay wrote:
> > 
> > [...] some script that finds the recent rename of all files and make
> > sure that it produces an expected result.
> 
> Suspicious undetected renames (excluding info files, git files, etc):
> 
>   pkgs/drracket/drracket/acks.rkt

I think of that as a new file that extracts a piece of an old file.

>   pkgs/drracket/drracket/drracket.extreg
>   pkgs/drracket/drracket/drracket.startmenu

New.

>   pkgs/drracket/help/bug-report.scrbl
>   pkgs/drracket/setup/plt-installer.scrbl
>   pkgs/drracket/version/tool.scrbl

Similar to "acks.rkt" --- new files that are a small pieces of old
files.

>   pkgs/gui-pkgs/gui-lib/mred/installer.rkt
>   pkgs/gui-pkgs/gui-lib/racket/gui/installer.rkt

This strikes me as actual history loss (due to many changes in a small
file).

>   pkgs/htdp/scribblings/htdp-langs/htdp-ptr.scrbl

New.

>   pkgs/racket-pkgs/racket-doc/file/scribblings/gif.scrbl

Mostly new, since it's a merger of pieces of two files into one.

>   pkgs/racket-pkgs/racket-doc/scribblings/raco/config.scrbl
>   pkgs/racket-pkgs/racket-index/scribblings/main/acks.scrbl
>   racket/lib/collects/compiler/private/configdir.rkt
>   racket/lib/collects/raco/main.extreg
>   racket/lib/collects/setup/private/setup-relative.rkt
>   racket/lib/collects/setup/winstrip.rkt
>   racket/src/racket/collects-path.rkt

New.

>   racket/src/racket/src/cstartup.inc

Not worth tracking.


> Going from the other direction, these are the files that existed before
> the rename commit that do not appear anywhere in the lists of rename
> chains:

Some are truly gone, and some are covered above. I don't understand why
most of them are in the list, though, since `git follow --log' on each
new location works for me (for the handful that I tried).


> Suspicious renamings (the first line is current name, then there are
> *some* of the previous names with the bogus one -- it's already
> "cleansed" from some known renames):
> 
>   racket/lib/collects/scheme/unit/lang/reader.rkt
>    collects/scheme/unit/lang/reader.rkt
>    collects/racket/unit/lang/reader.ss
>    collects/frtime/reactive/lang/reader.ss
>    collects/eopl/lang/reader.ss
>    collects/frtime/lang/reader.ss
>    collects/lazy/lang/reader.ss
>    collects/mred/lang/reader.ss
>   ==> Note: lots of these in varying rename chain lengths.  So these
>       should be done manually.
>
>   pkgs/deinprogramm/deinprogramm/signature/signature.rkt
>    collects/deinprogramm/contract/contract.rkt
> 
>   pkgs/drracket/drracket/drracket.creator
>    collects/drscheme/drscheme.creator
>    collects/help/help.creator
> 
>   pkgs/drracket/drscheme/drscheme.creator
>    collects/help/help.creator
> 
>   pkgs/future-visualizer-pkgs/future-visualizer-typed/info.rkt
>    collects/tests/pkg/test-pkgs/pkg-z/info.rkt
> 
>   pkgs/games/tally-maze/info.rkt
>    collects/games/same/info.rkt
>   ==> Many more info files too.
> 
> I didn't do more of this because I realized that this is not too useful
> now, with most (or all) of the bad detections happening in the past.

Well, exactly.


So, for the big reorganization of the tree, we seem to be losing
history (that separate move and change commits would clearly preserve)
on only a couple of 40-line files. I am more than satisfied with that
result, compared to what we get from day-to-day use of git --- and
particularly compared to the pain of trying to stage moves before edits
in the reorganization.


Posted on the dev mailing list.