[racket-dev] request for code review on fix for pr 13471

From: Danny Yoo (dyoo at hashcollision.org)
Date: Mon Feb 4 00:26:00 EST 2013

I've run the tests that use the lexer, and it appears to pass.  But
since it's parser-tools/lex, I'd like a second opinion on this, just
in case I'm doing something very silly.

I've put this in my branch 'pr13471':

    https://github.com/dyoo/racket/tree/pr13471

After someone takes a look and says ok, I can push the fix upstream.


On Fri, Feb 1, 2013 at 2:44 PM, Danny Yoo <dyoo at hashcollision.org> wrote:
> I've written up a patch for PR 13471:
>
>     https://github.com/dyoo/racket/commit/544918465b67cbf2e8ad40bd3c2b3ea90f33c085
>
> I just want a second pair of eyes just to make sure I've done it
> correctly.  I added a free-id-table that the parse function uses when
> walking across lex-abbrev syntaxes.  Does this look ok?

Posted on the dev mailing list.