[racket-dev] [plt] Push #27967: master branch updated
Where should we put the link to Planet?
- Main page
- New place
- Community
- Keep it on the navbar with packages
I can see good and bad things with most.
On Fri, Dec 20, 2013 at 4:32 PM, <jay at racket-lang.org> wrote:
> jay has updated `master' from 438942c059 to 9012f7b3d6.
> http://git.racket-lang.org/plt/438942c059..9012f7b3d6
>
> =====[ 5 Commits ]======================================================
> Directory summary:
> 85.5% pkgs/plt-services/meta/pkg-index/official/static/
> 7.0% pkgs/plt-services/meta/web/stubs/
> 3.8% pkgs/
> 3.5% racket/collects/pkg/
>
> ~~~~~~~~~~
>
> abc8b30 Jay McCarthy <jay at racket-lang.org> 2013-12-20 15:40
> :
> | Fix typo on pkg site
> :
> M pkgs/plt-services/meta/pkg-index/official/static/index.html | 2 +-
>
> ~~~~~~~~~~
>
> 6c4650e Jay McCarthy <jay at racket-lang.org> 2013-12-20 15:47
> :
> | Remove secret information from pkg error messages
> :
> M racket/collects/pkg/util.rkt | 4 +++-
>
> ~~~~~~~~~~
>
> 7faab4d Jay McCarthy <jay at racket-lang.org> 2013-12-20 15:53
> :
> | Fix PR14216
> :
> M racket/collects/pkg/lib.rkt | 5 +++--
>
> ~~~~~~~~~~
>
> 490e21f Jay McCarthy <jay at racket-lang.org> 2013-12-20 16:20
> :
> | Use Racket navbar on pkgs. and have navbar link to pkgs.
> |
> | Open question: Where does link to Planet go? Sam's new design has a natural place, but on the old site... it's not clear, community?
> :
> M .../meta/pkg-index/official/static/index.html | 2 +
> M .../meta/pkg-index/official/static/style.css | 49 ++++++++++++++++++++
> M pkgs/plt-services/meta/web/all.rkt | 2 +-
> C pkgs/plt-services/meta/{web/common => pkg-index/official/static}/logo.png (100%)
> M pkgs/plt-services/meta/web/config.rkt | 1 +
> M pkgs/plt-services/meta/web/stubs/all.rkt | 5 +-
> C pkgs/plt-services/meta/web/stubs/{planet.rkt => packages.rkt} (75%)
>
> ~~~~~~~~~~
>
> 9012f7b Jay McCarthy <jay at racket-lang.org> 2013-12-20 16:29
> :
> | Adding suggestion about 1.0 package versions
> :
> M .../racket-doc/pkg/scribblings/getting-started.scrbl | 5 ++++-
>
> =====[ Overall Diff ]===================================================
>
> pkgs/plt-services/meta/pkg-index/official/static/index.html
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/pkgs/plt-services/meta/pkg-index/official/static/index.html
> +++ NEW/pkgs/plt-services/meta/pkg-index/official/static/index.html
> @@ -10,6 +10,8 @@
> <link rel="stylesheet" href="/style.css">
> </head>
> <body>
> + <div class="racketnav"><div class="navcontent"><table border="0" cellpadding="0" cellspacing="0" width="100%"><tbody><tr><td><a href="http://racket-lang.org/"><span class="navtitle" style="font-size: 100px; vertical-align: middle;">(</span><span class="navtitle" style="font-size: 80px; vertical-align: middle;">(</span><span class="navtitle" style="font-size: 60px; vertical-align: middle;">(</span><span class="navtitle" style="font-size: 40px; vertical-align: middle;"> </span><img alt="[logo]" src="/logo.png" style="vertical-align: middle; margin: 13px 0.25em 0 0; border: 0;"><span class="navtitle" style="font-size: 80px; vertical-align: middle;">Racket</span><span class="navtitle" style="font-size: 40px; vertical-align: middle;"> </span><span class="navtitle" style="font-size: 60px; vertical-align: middle;">)</span><span class="navtitle" style="font-size: 80px; vertical-align: middle;">)</span><span class="navtitle" style="font-size: 100px; vertical-align: mid!
> dle;">)</span></a></td><td class="helpiconcell"><span class="helpicon"><a href="http://racket-lang.org/help.html">Need Help?</a></span></td></tr><tr><td colspan="2"><table width="100%"><tbody><tr><td class="navlinkcell"><span class="navitem"><span class="navlink"><a href="http://racket-lang.org/">About</a></span></span></td><td class="navlinkcell"><span class="navitem"><span class="navlink"><a href="http://racket-lang.org/download/">Download</a></span></span></td><td class="navlinkcell"><span class="navitem"><span class="navlink"><a href="http://docs.racket-lang.org/">Documentation</a></span></span></td><td class="navlinkcell"><span class="navitem"><span class="navcurlink"><a href="/">Packages</a></span></span></td><td class="navlinkcell"><span class="navitem"><span class="navlink"><a href="http://racket-lang.org/community.html">Community</a></span></span></td><td class="navlinkcell"><span class="navitem"><span class="navlink"><a href="http://racket-lang.org/learning.html">!
> Learning</a></span></span></td></tr></tbody></table></td></tr>!
> </tbody></table></div></div>
> +
> <div class="breadcrumb">
> <span><a href="/">Packages</a></span>
> <span id="logout"></span>
> @@ -55,7 +57,7 @@
> <tr><td>Description:</td><td><span id="pi_description"></span></td></tr>
> <tr><td>Tags:</td><td><span id="pi_tags"></span></td></tr>
> <tr id="pi_add_tag_row"><td></td><td><input type="text" id="pi_add_tag_text" class="text ui-widget-content ui-corner-all" /><button id="pi_add_tag_button">Add Tag</button></td></tr>
> - <tr id="pi_versions_row"><td>Versions Exceptions</td><td><table id="pi_versions"></table></td></tr>
> + <tr id="pi_versions_row"><td>Version Exceptions</td><td><table id="pi_versions"></table></td></tr>
> <tr id="pi_add_version_row"><td></td><td><label>Version:</label> <input type="text" id="pi_add_version_text" class="text ui-widget-content ui-corner-all" /><br /><label>Source:</label> <input type="text" id="pi_add_version_source_text" class="text ui-widget-content ui-corner-all" /><button id="pi_add_version_button">Add Version Exception</button></td></tr>
> <tr id="pi_dependencies_row"><td>Dependencies</td><td><span id="pi_dependencies"></span></td></tr>
> <tr id="pi_conflicts_row"><td>Conflicts</td><td><span id="pi_conflicts"></span></td></tr>
>
> pkgs/plt-services/meta/pkg-index/official/static/style.css
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/pkgs/plt-services/meta/pkg-index/official/static/style.css
> +++ NEW/pkgs/plt-services/meta/pkg-index/official/static/style.css
> @@ -154,3 +154,52 @@ a.possible {
> tr#pi_delete_row td {
> text-align: center;
> }
> +
> +/* racket nav */
> +.racketnav {
> + background-color: #000000;
> + color: #ffffff;
> + margin-bottom: 1em;
> + padding: 0.5em 0em;
> + white-space: nowrap;
> +}
> +.racketnav a {
> + color: #ffffff;
> + text-decoration: none;
> +}
> +.racketnav .navcontent {
> + margin-left: auto;
> + margin-right: auto;
> + width: 45em;
> + font-family: Optima, Arial, Verdana, Helvetica, sans-serif;
> +}
> +.racketnav .navtitle {
> + font-size: xx-large;
> + font-weight: bold;
> +}
> +.racketnav .navitem {
> + text-decoration: none;
> + font-size: 88%;
> +}
> +.racketnav .navlink a {
> + padding: 0em 1em;
> +}
> +.racketnav .navcurlink a {
> + padding: 0em 1em;
> + background-color: #555555;
> +}
> +.racketnav .navlink a:hover,
> +.racketnav .navcurlink a:hover {
> + background-color: #888888;
> +}
> +.racketnav .navlinkcell {
> + text-align: center;
> +}
> +.racketnav .helpiconcell {
> + text-align: right;
> + vertical-align: top;
> +}
> +.racketnav .helpicon {
> + font-weight: bold;
> + font-size: 88%;
> +}
>
> pkgs/plt-services/meta/web/all.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/pkgs/plt-services/meta/web/all.rkt
> +++ NEW/pkgs/plt-services/meta/web/all.rkt
> @@ -1,5 +1,5 @@
> #lang meta/web
>
> (require "www/all.rkt" "download/all.rkt" "minis/all.rkt" "stubs/all.rkt")
> -(set-navbar! (list main download documentation planet community learning)
> +(set-navbar! (list main download documentation packages community learning)
> main help)
>
> pkgs/plt-services/meta/web/config.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/pkgs/plt-services/meta/web/config.rkt
> +++ NEW/pkgs/plt-services/meta/web/config.rkt
> @@ -10,6 +10,7 @@
> ;; stubs usually use absolute paths for resources, since they're
> ;; templates that often get used in sub-dir pages too
> ("stubs/planet" "http://planet.racket-lang.org/" abs)
> + ("stubs/packages""http://pkgs.racket-lang.org/" abs)
> ("stubs/pre" "http://pre.racket-lang.org/" abs)
> ("stubs/git" "http://git.racket-lang.org/" abs)
> ("stubs/blog" "http://blog.racket-lang.org/" abs)
>
> pkgs/plt-services/meta/web/stubs/all.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/pkgs/plt-services/meta/web/stubs/all.rkt
> +++ NEW/pkgs/plt-services/meta/web/stubs/all.rkt
> @@ -1,9 +1,10 @@
> #lang racket/base
>
> -(provide documentation planet)
> +(provide documentation planet packages)
>
> (require "docs.rkt" ; for the doc tweaking script
> - "planet.rkt" "blog.rkt" ; these need to be copied to the service
> + ;; these need to be copied to the service
> + "packages.rkt" "planet.rkt" "blog.rkt"
> "pre.rkt" "git.rkt" ; / these are used on the
> "mailman.rkt" "dirlist.rkt" ; \ server directly
> "wiki.rkt")
>
> pkgs/racket-pkgs/racket-doc/pkg/scribblings/getting-started.scrbl
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/pkgs/racket-pkgs/racket-doc/pkg/scribblings/getting-started.scrbl
> +++ NEW/pkgs/racket-pkgs/racket-doc/pkg/scribblings/getting-started.scrbl
> @@ -472,7 +472,10 @@ changing a version is optional, and the @tech{package catalog}
> ignores version declarations; in particular, a package is a candidate
> for updating when its @tech{checksum} changes, independent of whether
> the package's version changes or even in which direction the version
> -changes.}
> +changes. We suggest using a version smaller than @racket["1.0"] to
> +indicate that a package's interface is unstable and changing it to
> + at racket["1.0"] when you are ready to commit to backwards compatibility
> +going forward.}
>
> @item{Packages should not combine large sets of utilities libraries
> with other functionality. For example,
>
> racket/collects/pkg/lib.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/racket/collects/pkg/lib.rkt
> +++ NEW/racket/collects/pkg/lib.rkt
> @@ -2095,7 +2095,7 @@
> (lambda (m)
> (match-define (pkg-info orig-pkg checksum auto?) m)
> (match orig-pkg
> - [`(,(or 'link 'static-link) ,_)
> + [`(,(or 'link 'static-link) ,orig-pkg-dir)
> (if must-update?
> (pkg-error (~a "cannot update linked packages~a\n"
> " package name: ~a\n"
> @@ -2104,7 +2104,8 @@
> " without `--link'"
> " without new link")
> pkg-name
> - orig-pkg)
> + (normalize-path
> + (path->complete-path orig-pkg-dir (pkg-installed-dir))))
> null)]
> [`(dir ,_)
> (if must-update?
>
> racket/collects/pkg/util.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/racket/collects/pkg/util.rkt
> +++ NEW/racket/collects/pkg/util.rkt
> @@ -98,7 +98,9 @@
> (unless api-bs
> (error 'package-url->checksum
> "could not connect to GitHub\n URL: ~a"
> - (url->string api-u)))
> + (url->string
> + (struct-copy url api-u
> + [query query]))))
> (define branches
> (read-json (open-input-bytes api-bs)))
> (unless (and (list? branches)
>
> *** See above for renames and copies ***