[racket-dev] [plt] Push #25762: master branch updated

Great, thanks!


On Mon, Nov 26, 2012 at 3:24 PM, Robby Findler
<robby at eecs.northwestern.edu>wrote:

> Okay, I've pushed a fix for a bug that would explain the latest
> stacktrace. Please let me know if you spot more problems!
>
> Thanks,
> Robby
>
> On Mon, Nov 26, 2012 at 12:18 PM, Robby Findler
> <robby at eecs.northwestern.edu> wrote:
> > Well, probably what's happening is that you got an error earlier and that
> > error left DrRacket in a strange state. Are you seeing any of this before
> > you see the first "internal error" box?
> >
> > Meanwhile, I've pushed 2 fixes and the stacktrace you sent earlier is
> > definitely helping me hone in on another one (the one you saw while
> looking
> > at an error in drracket).
> >
> > (The commit below actually fixes one bug.)
> >
> > Robby
> >
> >
> > On Monday, November 26, 2012, James Swaine wrote:
> >>
> >> Is anyone else seeing strange behavior in DrRacket since this latest
> round
> >> of DrRacket-related commits?  Here's what I'm seeing:
> >>
> >> -With definitions/interactions side by side, sometimes the vertical
> scroll
> >> bar in the interactions window disappears for no reason.
> >> -Saving a file can sometimes render the definitions window unresponsive.
> >> Occasionally the definitions window will still respond but won't allow
> me to
> >> edit code anymore.
> >> -If I switch from one tab to another and then back to the original, the
> >> definitions window sometimes becomes blank.
> >> -If I run a program that raises an error, viewing the stack trace by
> >> clicking on the icon in the interactions window can cause DrRacket to
> raise
> >> an error (I only saw this once, and unfortunately I don't have the error
> >> message).
> >> -The status bar area that displays information about background
> expansion
> >> can arbitrarily disappear, however the label providing the information
> (e.g.
> >> "Background expansion finished") remains and appears to be superimposed
> on
> >> top of the definitions window.
> >>
> >> I don't have specific steps to reproduce yet so I'm not able to submit
> bug
> >> report(s), but I'll see what I can come up with.  Maybe I'm the only one
> >> experiencing this.
> >>
> >>
> >>
> >>
> >> On Mon, Nov 26, 2012 at 10:55 AM, <robby at racket-lang.org> wrote:
> >>>
> >>> robby has updated `master' from 569af52ffc to ba89a5da92.
> >>>   http://git.racket-lang.org/plt/569af52ffc..ba89a5da92
> >>>
> >>> =====[ One Commit
> ]=====================================================
> >>> Directory summary:
> >>>  100.0% collects/framework/private/
> >>>
> >>> ~~~~~~~~~~
> >>>
> >>> ba89a5d Robby Findler <robby at racket-lang.org> 2012-11-26 07:54
> >>> :
> >>> | fix bug in error checking code
> >>> :
> >>>   M collects/framework/private/text.rkt | 14 ++++++++------
> >>>
> >>> =====[ Overall Diff
> ]===================================================
> >>>
> >>> collects/framework/private/text.rkt
> >>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>> --- OLD/collects/framework/private/text.rkt
> >>> +++ NEW/collects/framework/private/text.rkt
> >>> @@ -42,12 +42,14 @@
> >>>  (define-struct rectangle (left top right bottom style color)
> #:inspector
> >>> #f)
> >>>
> >>>  (define (build-rectangle left top right bottom style color)
> >>> -  (when (right . < . left)
> >>> -    (error 'build-rectangle "found right to the right of left: ~s"
> >>> -           (list left top right bottom style color)))
> >>> -  (when (bottom . < . top)
> >>> -    (error 'build-rectangle "found bottom above top: ~s"
> >>> -           (list left top right bottom style color)))
> >>> +  (unless (or (symbol? right) (symbol? left))
> >>> +    (when (right . < . left)
> >>> +      (error 'build-rectangle "found right to the right of left: ~s"
> >>> +             (list left top right bottom style color))))
> >>> +  (unless (or (symbol? top) (symbol? bottom))
> >>> +    (when (bottom . < . top)
> >>> +      (error 'build-rectangle "found bottom above top: ~s"
> >>> +             (list left top right bottom style color))))
> >>>    (make-rectangle left top right bottom style color))
> >>>
> >>>
> >>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.racket-lang.org/dev/archive/attachments/20121126/1f119daa/attachment-0001.html>