[racket-dev] The Clark XML tests & licensing

I just committed a fix to this.

Jay

On Thu, Mar 8, 2012 at 12:06 PM, Jay McCarthy <jay.mccarthy at gmail.com> wrote:
> I think we should just use the system 'unzip', since we currently on
> test on platforms that have it anyways. DrDr has unzip and my machines
> do (I maintain XML.)
>
> I am also at fault for this, so I can fix it.
>
> Jay
>
>
> On 3/8/12, Matthew Flatt <mflatt at cs.utah.edu> wrote:
>> We have a `file/zip' library for creating ".zip" files, but we need a
>> `file/unzip' library. It should be fairly easy to implement in terms of
>> `inflate'. Maybe there's an implementation on Planet already?
>>
>> Also, there's a limited `unzip' in "scribble/lncs/lang.rkt", because I
>> needed it to automatically download and unpack the LNCS style file.
>> That's possibly a useful starting point, if no other is available.
>>
>> At Thu, 8 Mar 2012 11:30:23 -0600, Robby Findler wrote:
>>> Oh, but I see that this doesn't actually create the files. Probably
>>> something needs to be added to the library.
>>>
>>> Sorry.
>>>
>>> Robby
>>>
>>> On Thu, Mar 8, 2012 at 11:29 AM, Robby Findler
>>> <robby at eecs.northwestern.edu> wrote:
>>> > I think you want 'inflate'. IIUC, .zip files contain 'pkzip'-format
>>> > compressed stuff.
>>> >
>>> > Robby
>>> >
>>> > On Thu, Mar 8, 2012 at 11:26 AM, Sam Tobin-Hochstadt <samth at ccs.neu.edu>
>>> >
>>> wrote:
>>> >> On Thu, Mar 8, 2012 at 11:52 AM, Robby Findler
>>> >> <robby at eecs.northwestern.edu> wrote:
>>> >>> Doesn't file/gunzip do that?
>>> >>
>>> >> From the documentation, that seems to be about files that use gzip,
>>> >> not zip.  I didn't think they were the same, but I don't know much
>>> >> about this stuff.
>>> >>
>>> >> Trying it, it doesn't seem to work:
>>> >>
>>> >> -> (gunzip "xmltest.zip")
>>> >> ; gnu-unzip: bad header [,bt for context]
>>> >>
>>> >>
>>> >>> On Thu, Mar 8, 2012 at 9:39 AM, Sam Tobin-Hochstadt
>>> >>> <samth at ccs.neu.edu>
>>> wrote:
>>> >>>> Summary: we are currently violating the license of James Clark's XML
>>> >>>> test suite, and should fix this.
>>> >>>>
>>> >>>> Currently, the `tests/xml' directory [1] contains a comprehensive
>>> >>>> collection tests for XML parsing from James Clark [2].  The
>>> >>>> readme.html file [3] in that directory states the license of that
>>> >>>> test
>>> >>>> suite:
>>> >>>>
>>> >>>>  Copyright (C) 1998 James Clark. All rights reserved. Permission is
>>> >>>>  granted to copy and modify this collection in any way for internal
>>> >>>> use
>>> >>>>  within a company or organization. Permission is granted to
>>> >>>>  redistribute the file <code>xmltest.zip</code> containing this
>>> >>>>  collection to third parties provided that no modifications of any
>>> >>>> kind
>>> >>>>  are made to this file. Note that permission to distribute the
>>> >>>>  collection in any other form is not granted.
>>> >>>>
>>> >>>> See in particular the last sentence.  We're clearly violating this
>>> >>>> license, since we distribute the unzipped collection.  We need to fix
>>> >>>> this.
>>> >>>>
>>> >>>> Fortunately, this should be easy to fix.  We need to do the
>>> >>>> following:
>>> >>>>
>>> >>>> 1. Remove the 'clark-tests' directory.
>>> >>>> 2. Add the 'xmltest.zip' file.
>>> >>>> 3. Unzip the file on-demand when running the tests.
>>> >>>>
>>> >>>> Currently, we don't have a Racket interface to unzip files.  We could
>>> >>>> use the command-line 'unzip' tool, or write such an interface., or
>>> >>>> perhaps someone's already written one.
>>> >>>>
>>> >>>> [1]
>>> https://github.com/plt/racket/tree/master/collects/tests/xml/clark-tests
>>> >>>> [2] ftp://ftp.jclark.com/pub/xml/xmltest.zip
>>> >>>> [3]
>>> https://github.com/plt/racket/blob/master/collects/tests/xml/clark-tests/readme.
>>> html
>>> >>>> --
>>> >>>> sam th
>>> >>>> samth at ccs.neu.edu
>>> >>>> _________________________
>>> >>>>  Racket Developers list:
>>> >>>>  http://lists.racket-lang.org/dev
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> sam th
>>> >> samth at ccs.neu.edu
>>>
>>> _________________________
>>>   Racket Developers list:
>>>   http://lists.racket-lang.org/dev
>>
>> _________________________
>>   Racket Developers list:
>>   http://lists.racket-lang.org/dev
>>
>
>
> --
> Jay McCarthy <jay at cs.byu.edu>
> Assistant Professor / Brigham Young University
> http://faculty.cs.byu.edu/~jay
>
> "The glory of God is Intelligence" - D&C 93



-- 
Jay McCarthy <jay at cs.byu.edu>
Assistant Professor / Brigham Young University
http://faculty.cs.byu.edu/~jay

"The glory of God is Intelligence" - D&C 93