[racket-dev] Pre-Release Checklist for v5.1.2

I see. Thanks for the explanation. You're right: let's leave it out.

Robby

On Thursday, July 21, 2011, Eli Barzilay <eli at barzilay.org> wrote:
> You did the commit on the 6th, before the release branch was made, but
> pushed it on the 8th, after that.  (You can use "git show
> --format=fuller fbccf38" and see the different commit date due to
> rebasing, and also the email for the push is from the 8th.)  Given
> that it was a relatively large commit on something you're usually very
> careful with, I assumed that you didn't intend for it to be included
> so I didn't ask about it later...
>
> Should it be included?  If so, then should planet tests be done again?
>
>
>
> 50 minutes ago, Robby Findler wrote:
>> I believe that I made this commit:
>>
>> fbccf38d50e5f622c0c96a8c09b423decbd01269
>>
>> on July 6th and that is the diff for that commit:
>>
>> http://git.racket-lang.org/plt/blobdiff/b98e1b189a2afab1ba9c67f1e1432fb2cd28a552..fbccf38d50e5f622c0c96a8c09b423decbd01269:/collects/tests/planet/cmdline-tool.rkt
>>
>> but in the cmdline-tool.rkt file that I see in the bundle that I
>> downloaded, it looks like the "minus" part of the diff, not the
>> "plus" part.
>>
>> Am I doing something wrong or is the bundle wrong? (This is the
>> "windows full" version.)
>
> --
>           ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
>                     http://barzilay.org/                   Maze is Life!
>