[racket-dev] [plt] Push #22426: master branch updated

On Sun, Apr 10, 2011 at 9:24 PM, Jon Rafkind <rafkind at cs.utah.edu> wrote:
> If I cilck on the line:column thing in the toolbar area next to the gc
> icon it and select 'show line and column numbers' then the line:column
> becomes hidden. If I then click in the same area to bring up the popup I
> see that 'show line and column numbers' is still selected and clicking
> it does not bring back the line:column display.

That's because the focus is no longer on an editor, but on that thing
you clicked on.

Probably I should make the focus go back where it was (I think that
information's there).

> Also if line:column is being shown and I click 'show character offsets'
> (which did not already have a checkmark next to it) then the line:column
> goes away and I see 'show line and column numbers' without a checkmark
> next to it (when before it did have one).

Yes, and you now see a check mark next to 'show character offsets',
right? That's what's supposed to happen anyways.

> A further issue seems to be if the line:column display is hidden then
> its not clear where to click to get it back. Not that I really care but
> I don't see the problem with always displaying either line:column or
> character offset (or maybe both).

I think that's the same issue.

Robby

> On 04/10/2011 06:38 PM, robby at racket-lang.org wrote:
>> robby has updated `master' from 6b503fa947 to c4e0559db4.
>>   http://git.racket-lang.org/plt/6b503fa947..c4e0559db4
>>
>> =====[ 3 Commits ]======================================================
>>
>> Directory summary:
>>   17.2% collects/drracket/private/
>>   23.5% collects/framework/private/
>>   53.7% collects/scribblings/framework/
>>    5.5% collects/string-constants/
>>
>> ~~~~~~~~~~
>>
>> 2c2669b Robby Findler <robby at racket-lang.org> 2011-04-10 17:43
>> :
>> | fix the handling of the drracket:show-line-numbers? preference
>> |   so the line numbers change no matter who sets the preference
>> :
>>   M collects/drracket/private/main.rkt |   10 +---------
>>   M collects/drracket/private/unit.rkt |   14 +++++++++++++-
>>
>> ~~~~~~~~~~
>>
>> f3936ac8 Robby Findler <robby at racket-lang.org> 2011-04-10 19:30
>> :
>> | correct capitolization for menu items
>> :
>>   M collects/string-constants/english-string-constants.rkt |    4 ++--
>>
>> ~~~~~~~~~~
>>
>> c4e0559 Robby Findler <robby at racket-lang.org> 2011-04-10 19:35
>> :
>> | made the line/column thingy's popup menu be able to show the line numbers in the definitions window
>> |   - added add-line-number-menu-items
>> |   - some minor fixes to the docs
>> |   related to discussion in PR 11837
>> :
>>   M collects/drracket/private/unit.rkt                     |   11 ++
>>   M collects/framework/private/frame.rkt                   |   56 ++++---
>>   M collects/scribblings/framework/frame.scrbl             |  117 ++++++-------
>>   M collects/string-constants/english-string-constants.rkt |    1 +
>
>