[racket-dev] rename + changes => bad? (was: Fwd: [plt] Push #21110: master branch updated)

On Sep 17, 2010, at 11:03 AM, Sam Tobin-Hochstadt wrote:

> On Fri, Sep 17, 2010 at 1:36 PM, John Clements
> <clements at brinckerhoff.org> wrote:
>> Oof... it looks like doing a rename plus a few changes pretty effectively hides those changes, though I can dig them out with 'git annotate'.  Do we have a policy (or should we have) a policy stating that you shouldn't put a rename and modifications to that file in the same commit?
> 
> I believe that this is an issue with Eli's email formatting script,
> and not with git itself (the github diff is fine:
> http://github.com/plt/racket/commit/a095ebc326aa35b5b19f314080855db5d55ed49b

Github seems to do a better job than 'git diff' or 'git show' with these; both of these simply showed me an entire file of lines added and an entire file of lines deleted.

John


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4669 bytes
Desc: not available
URL: <http://lists.racket-lang.org/dev/archive/attachments/20100917/79f9b0b8/attachment.p7s>