[plt-dev] Re: [plt] Push #20286: master branch updated

At Sat, 22 May 2010 06:47:44 -0400, Eli Barzilay wrote:
> On May 21, jay at racket-lang.org wrote:
> > 
> > src/racket/gc/new_hblk.c
> > ~~~~~~~~~~~~~~~~~~~~~~~~
> > --- OLD/src/racket/gc/new_hblk.c
> > +++ NEW/src/racket/gc/new_hblk.c
> > @@ -164,7 +164,8 @@ ptr_t GC_build_fl(struct hblk *h, size_t sz, GC_bool 
> clear, ptr_t list)
> >     * put p (which is now head of list of objects in *h) as first
> >     * pointer in the appropriate free list for this size.
> >     */
> > -      obj_link(h -> hb_body) = list;
> > +	  word *tmp = (word *)h->hb_body;
> > +      obj_link(tmp) = list;
> >        return ((ptr_t)p);
> >  }
> 
> It's not clear to me what this is trying to do, but this breaks on
> windows.

The problem is the variable declaration in the middle of a block. I'll
fix it.

> > src/racket/gc/mark_rts.c
> > ~~~~~~~~~~~~~~~~~~~~~~~~
> > --- OLD/src/racket/gc/mark_rts.c
> > +++ NEW/src/racket/gc/mark_rts.c
> > @@ -369,7 +369,8 @@ ptr_t GC_approx_sp(void)
> >  #   ifdef _MSC_VER
> >  #     pragma warning(disable:4172)
> >  #   endif
> > -    return((ptr_t)(&dummy));
> > +	ptr_t addr = ((ptr_t)(&dummy));
> > +    return addr;
> 
> This too.

Ditto.

> > src/gracket/wxs/list.xci
> > ~~~~~~~~~~~~~~~~~~~~~~~~
> > --- OLD/src/gracket/wxs/list.xci
> > +++ NEW/src/gracket/wxs/list.xci
> >  [...]
> > -static Scheme_Object *l_MAKE_LIST(l_TYPE l_POINT *f, l_INTTYPE c)
> > +MAYBE_UNUSED static Scheme_Object *l_MAKE_LIST(l_TYPE l_POINT *f, l_INTTYPE 
> c)
> 
> This (and many others) looks suspicious.

It's ok.