[plt-dev] Commit emails based off of plt:responsible

From: Stevie Strickland (sstrickl at ccs.neu.edu)
Date: Fri Dec 11 13:18:03 EST 2009

This is an aside, though related to other discussions that have been happening recently (bug tracking, committing to others' code):

Though I'm sure the coverage is incomplete, we currently have a plt:responsible SVN property that suggests who the maintainer is for a particular piece of the PLT codebase.  Would it make sense to add, as part of the SVN mailer hook, that if plt:responsible is set for a committed piece of code, the person listed in plt:responsible is mailed with the commit message/diff?

At places I've worked before, everyone had easy access (through newsgroups) to all the commit messages (branches and trunk), and that led to a level of code review that was very successful.  While I know that most here are not able to participate in that level of code review[0], perhaps receiving commit emails that are directly related to code in which you're interested, either signified by plt:responsible or perhaps a new property, would be more acceptable.

Whether or not such commit emails include branches is another part of the discussion.  It's often useful to catch mistakes made by other people on branches before things hit trunk, though, so I'm not sure I'd suggest this only take effect for trunk commits.  Having to look through a branch->trunk merge just to find the bits that interests you is annoying, and if you've been getting the branch commits in the meantime, you can usually just assume you've seen all the appropriate changes in much more digestible chunks.


[0] I believe Sam and I are the only ones who currently get all the commit messages, and Eli, Jon Rafkind, and Jay just get all the trunk commits.

Posted on the dev mailing list.